[QwixOdmlQuantizationBoundary] Fix tfl.mul element type mismatch in selective quantization.#254
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
[QwixOdmlQuantizationBoundary] Fix tfl.mul element type mismatch in selective quantization.#254copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_900510098
branch
3 times, most recently
from
67c9e64 to
af12f15
Compare
…elective quantization.
This change stabilizes the Qwix ODML quantization pipeline by enforcing strict boundaries between quantized and floating-point regions.
Key changes:
- Enforced that `rule is None` or `rule.act_qtype is None` in `_maybe_fake_quant` implies full precision (FP), clearing all `_FQ_` metadata and returning immediately. This prevents illegal metadata propagation ("leakage") across operations without defined quantization rules.
- Updated `FinalOutput` to explicitly retrieve and pass the `previous_rule` to `_maybe_fake_quant`, preserving the intended delayed quantization behavior for model outputs while maintaining strict boundaries elsewhere.
These changes ensure that quantization intent does not leak across boundaries in a way that breaks binary operations like multiplication, resolving MLIR assertion failures during TFLite conversion.
PiperOrigin-RevId: 900510098
copybara-service
bot
force-pushed
the
test_900510098
branch
from
af12f15 to
cc13110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixOdmlQuantizationBoundary] Fix tfl.mul element type mismatch in selective quantization.
This change stabilizes the Qwix ODML quantization pipeline by enforcing strict boundaries between quantized and floating-point regions.
Key changes:
rule is Noneorrule.act_qtype is Nonein_maybe_fake_quantimplies full precision (FP), clearing all_FQ_metadata and returning immediately. This prevents illegal metadata propagation ("leakage") across operations without defined quantization rules.FinalOutputto explicitly retrieve and pass theprevious_ruleto_maybe_fake_quant, preserving the intended delayed quantization behavior for model outputs while maintaining strict boundaries elsewhere.These changes ensure that quantization intent does not leak across boundaries in a way that breaks binary operations like multiplication, resolving MLIR assertion failures during TFLite conversion.