[QwixQuantStat] Refactor _collect_quant_stat to _update_and_get_quant_stat.#258
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
[QwixQuantStat] Refactor _collect_quant_stat to _update_and_get_quant_stat.#258copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…_stat. The internal method _collect_quant_stat was misleading as it both updates the running quantization statistics (using SimpleMovingAverage) and returns the current averaged calibration data. This CL renames it to _update_and_get_quant_stat across the qwix codebase to better reflect this dual responsibility. Implementation Details: - Updated OdmlQatProvider and QtProvider to use the new method name. - Clarified docstrings to explain the update-and-return behavior. - Updated internal references in odml_ops.py and experimental scripts. - Associated configuration field names (e.g., lhs_collect_quant_stat) are kept as-is to maintain API stability while the underlying implementation is improved. - Fixed a syntax error in an experimental script blocking formatting. PiperOrigin-RevId: 900895282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixQuantStat] Refactor _collect_quant_stat to _update_and_get_quant_stat.
The internal method _collect_quant_stat was misleading as it both updates the running quantization statistics (using SimpleMovingAverage) and returns the current averaged calibration data.
This CL renames it to _update_and_get_quant_stat across the qwix codebase to better reflect this dual responsibility.
Implementation Details: