fix(a11y): enhance label on track santa button#238
Open
KenTandrian wants to merge 4 commits intogoogle:mainfrom
Open
fix(a11y): enhance label on track santa button#238KenTandrian wants to merge 4 commits intogoogle:mainfrom
KenTandrian wants to merge 4 commits intogoogle:mainfrom
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes an accessibility issue where the "Track Santa" button (the Santa hat icon) on the tracker map was announced as "object object" by screen readers. This was due to a missing
aria-labelon the button instance and an issue with how thesanta-buttoncomponent handled undefined attributes.Changes
aria-labelto the Santa hat button inmodvil-tracker.jsusing the localized stringtracker_track(e.g., "Track Santa"). This ensures screen readers clearly announce the button's purpose and action.SantaButtonElementinsanta-button.jsto properly useifDefinedforaria-labelandaria-expanded. This preventsnothingorundefinedvalues from being rendered as stringified objects (like "object object") in the DOM.Impacted UI components
modvil-tracker)santa-button)