This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Use a specified filename to store downloaded bleu script.#182
Open
wb14123 wants to merge 1 commit intogoogle:masterfrom
Open
Use a specified filename to store downloaded bleu script.#182wb14123 wants to merge 1 commit intogoogle:masterfrom
wb14123 wants to merge 1 commit intogoogle:masterfrom
Conversation
This can avoid generate lots of temp files.
Author
|
Hi, how is this PR going? I think this is really useful. |
Contributor
|
Why the script should download multiple-bleu.perl multiple times? |
Author
|
I think with this we could make sure that we are using the newest version. But in a single training, it is better to not download the script every time we need to count bleu score. However it is a little difficult to implement since we need to pass a flag to check if it is the first time to count it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch can avoid generate lots of temp files for bleu script.
Because the training will take much time and count the bleu metrics many times, there will be lots of temp files after the training.