This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Stop losing channels when nodes are modified.#30
Open
baptr wants to merge 1 commit into
Open
Conversation
SetNode was deleting the old copy of the node before writing the new one, which cascaded to delete channels. Now the new node is set up in place, which maintains more state. If it's a rename or delete, the old node is cleaned up after.
DrJosh9000
reviewed
Jun 30, 2018
DrJosh9000
left a comment
DrJosh9000
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I think this is better than my solution. Will take another look tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetNode was deleting the old copy of the node before writing the new
one, which cascaded to delete channels.
Now the new node is set up in place, which maintains more state. If it's
a rename or delete, the old node is cleaned up after.
This probably intersects with 717891c, but opening it for discussion anyway.