Skip to content

fix: verify gitlab package install script#74

Merged
LanceWray merged 1 commit into
google:mainfrom
kiwigitops:harden-gitlab-install-script
Jun 2, 2026
Merged

fix: verify gitlab package install script#74
LanceWray merged 1 commit into
google:mainfrom
kiwigitops:harden-gitlab-install-script

Conversation

@kiwigitops

Copy link
Copy Markdown
Contributor

Summary

  • replace the GitLab curl | bash bootstrap path with download, SHA-256 verification, then execution
  • expose the expected script hash as a Terraform variable so deployments can intentionally update it
  • remove the downloaded script after startup completes

Fixes #22.

Validation

  • verified the default SHA-256 against the current GitLab package repository install script
  • git diff --check

@aghassemlouei aghassemlouei added the enhancement New feature or request label May 28, 2026
@aghassemlouei aghassemlouei requested a review from LanceWray May 28, 2026 16:32
@aghassemlouei

Copy link
Copy Markdown
Collaborator

Thank you for the contribution @kiwigitops! I've requested a review from @LanceWray until I get more familiar with the codebase and we incorporate more automated tests.

Comment thread blueprints/fedramp-high/gitlab/main.tf Outdated
@kiwigitops kiwigitops force-pushed the harden-gitlab-install-script branch from 682c5f1 to bba7a4d Compare June 1, 2026 21:54
@LanceWray LanceWray merged commit e12f2d4 into google:main Jun 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] GitLab blueprint startup script executes remote code without integrity verification

3 participants