Skip to content

Update 1-resman tfvars sample to align with TDD example#78

Open
LanceWray wants to merge 3 commits into
mainfrom
wraylance-resman-tfvars-samp-update
Open

Update 1-resman tfvars sample to align with TDD example#78
LanceWray wants to merge 3 commits into
mainfrom
wraylance-resman-tfvars-samp-update

Conversation

@LanceWray

Copy link
Copy Markdown
Collaborator

Description

Update 1-resman tfvars sample to align with TDD example

Fixes # (GitHub issue id)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: (If this PR helps satisfy or modifies control implementations, list them here)

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in documentation/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP High, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

Deployed locally using updated sample tfvars

Comment thread fast/stages-aw/1-resman/terraform.tfvars.sample Outdated
Comment thread fast/stages-aw/1-resman/terraform.tfvars.sample Outdated

@woodham1 woodham1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to do it here in resman, we should probably do the same for the other samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants