This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Handle docstring in raw format in main source file#83
Open
smit-hinsu wants to merge 2 commits intogoogle:masterfrom
Open
Handle docstring in raw format in main source file#83smit-hinsu wants to merge 2 commits intogoogle:masterfrom
smit-hinsu wants to merge 2 commits intogoogle:masterfrom
Conversation
Author
|
@davidstanke Please take a look. |
duggelz
approved these changes
Nov 21, 2018
Contributor
duggelz
left a comment
duggelz
left a comment
There was a problem hiding this comment.
Looks good to me. However, I can't merge this, since I no longer work for Google.
|
Hey! I'm not comfortable merging this -- I'm not engaged on implementation of Bazel/Python features. So I'll pass to @brandjon, who is. |
Author
|
Thanks @davidstanke for adding Jon on the PR. |
Contributor
|
I'm not familiar with subpar's implementation details, but the change looks simple enough, and Douglas already signed off on it. |
Contributor
|
Hm, actually I don't appear to have merge rights in this repo. Not sure who does. I'll look into that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with ./run_tests.sh