Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Some fixes#1

Open
caruccio wants to merge 1 commit into
google:masterfrom
caruccio:updates
Open

Some fixes#1
caruccio wants to merge 1 commit into
google:masterfrom
caruccio:updates

Conversation

@caruccio

Copy link
Copy Markdown
  • Update to python 3
  • Fix FD regex
  • Print shutdown() prior executing

Tested on Mac OS

- Update to python 3
- Fix FD regex
- Print shutdown() prior executing
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@caruccio

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@bogdad

bogdad commented Aug 20, 2018

Copy link
Copy Markdown

can confirm, does not work without regexp fix, please merge!

@Sjors

Sjors commented Oct 25, 2019

Copy link
Copy Markdown

Succesfully tested 82bfcfb on macOS 10.15 Catalina.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants