Ensure BoringSSL error queue is cleared#252
Open
YATIN072007 wants to merge 1 commit intogoogle:masterfrom
Open
Ensure BoringSSL error queue is cleared#252YATIN072007 wants to merge 1 commit intogoogle:masterfrom
YATIN072007 wants to merge 1 commit intogoogle:masterfrom
Conversation
Fixes google#63. This change updates the FFI implementation to ensure that the BoringSSL thread-local error queue is always cleared after operations, regardless of success or failure. This prevents stale errors from contaminating subsequent cryptographic operations or leaking across asynchronous boundaries. Also adds test/thread_local_error_test.dart to verify this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces strict clearing of the BoringSSL thread-local error queue after every operation. By ensuring ERR_clear_error is called unconditionally on every exit from FFI scopes and check helpers, This ensures that no errors are left behind to affect future operations.