Fix GetLastSupportedIphoneSimType to prevent iPhone 6s Plus fallback for modern iOS#74
Open
bc-lee wants to merge 2 commits intogoogle:masterfrom
Open
Fix GetLastSupportedIphoneSimType to prevent iPhone 6s Plus fallback for modern iOS#74bc-lee wants to merge 2 commits intogoogle:masterfrom
bc-lee wants to merge 2 commits intogoogle:masterfrom
Conversation
Author
|
The first commit actually belongs to another issue, #73, but it needs to be included to handle these test cases. |
bc-lee
force-pushed
the
fix-device-selection
branch
from
5da02a8 to
5d5c184
Compare
…for modern iOS The GetLastSupportedIphoneSimType function was incorrectly returning iPhone 6s Plus for iOS versions it cannot support (e.g., iOS 18.5), contributing to the broader issue where outdated iPhone 6s Plus becomes the default simulator device. Changes: - Fix compatibility logic to check both min_os_version AND max_os_version - Remove incorrect .reverse() call that caused oldest-first device ordering - Update function documentation to reflect correct behavior - Add mocked tests with regression protection The iPhone 6s Plus (max iOS 15.99) should never be returned for iOS 18.5+, preventing downstream tools from defaulting to this obsolete device.
bc-lee
force-pushed
the
fix-device-selection
branch
from
5d5c184 to
87179d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetLastSupportedIphoneSimType function was incorrectly returning iPhone 6s Plus
for iOS versions it cannot support (e.g., iOS 18.5), contributing to the broader
issue where outdated iPhone 6s Plus becomes the default simulator device.
Changes:
The iPhone 6s Plus (max iOS 15.99) should never be returned for iOS 18.5+,
preventing downstream tools from defaulting to this obsolete device.
Related: bazelbuild/rules_apple#2773