fix(md): escape template literal metacharacters in bash fence blocks#1457
Open
Mr-In4inci3le wants to merge 1 commit intogoogle:mainfrom
Open
fix(md): escape template literal metacharacters in bash fence blocks#1457Mr-In4inci3le wants to merge 1 commit intogoogle:mainfrom
Mr-In4inci3le wants to merge 1 commit intogoogle:mainfrom
Conversation
Author
|
Hi @antonmedv @antongolub, just following up on this PR. Happy to make any changes or address feedback if needed. Thanks for your time! |
Mr-In4inci3le
force-pushed
the
fix/bash-fence-js-injection
branch
from
eaed090 to
927650b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash fence blocks in
transformMarkdown()embed content inside a JS tagged template literal (await $...``). This means${...}andBacktick characters in bash fence content were interpreted as JS template literal syntax rather than literal shell text.
This commit escapes
\,`, and${in bash fence lines before embedding them in the template literal, so the content is alwaystreated as literal shell commands.
Normal shell syntax (
$VAR,$(cmd)) is unaffected.Security regression tests added to
test/md.test.ts.