fix(bq_driver): Fix encoding for SAP HANA#1506
Open
shivamd-gpartner wants to merge 32 commits into
Open
Conversation
shivamd-gpartner
temporarily deployed
to
internal
April 28, 2026 11:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
shivamd-gpartner
force-pushed
the
test_hana
branch
from
April 28, 2026 12:14
735d19f to
873b9da
Compare
shivamd-gpartner
temporarily deployed
to
internal
April 28, 2026 12:16 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
shivamd-gpartner
temporarily deployed
to
internal
April 28, 2026 14:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
shivamd-gpartner
force-pushed
the
test_hana
branch
13 times, most recently
from
May 5, 2026 10:41
311c71e to
814c1fb
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
from
May 6, 2026 08:26
511f04e to
7b8b154
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
3 times, most recently
from
May 6, 2026 12:56
f9232a2 to
9ce5ad1
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
4 times, most recently
from
May 7, 2026 07:09
07fe46c to
c350b18
Compare
sachinpro
reviewed
May 7, 2026
| std::regex named_pattern(R"([:@]\w+)"); | ||
|
|
||
| // Check for positional parameters | ||
| if (std::regex_search(query, positional_pattern)) { |
Collaborator
There was a problem hiding this comment.
Let's deep dive into the reason this was crashing.
Let's print query and positional_pattern. Let's write a small c++ application to verify that it crashes independently.
Collaborator
Author
There was a problem hiding this comment.
Have verified and independently it works, issue is due to SAP HANA interfering with std::regex ABI , using re2 regex instead
shivamd-gpartner
force-pushed
the
test_hana
branch
from
May 12, 2026 05:38
3ae14c6 to
79a7205
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
from
July 21, 2026 10:49
2105884 to
f29910c
Compare
shivamd-gpartner
force-pushed
the
test_hana
branch
from
July 21, 2026 10:54
f29910c to
f7a519d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the encoding which was causing the issue on SAP HANA and had a different size of SQLWCHAR that the one it was built with . Another issue was the usage of std::regex crashing the driver due conflicting ABI with SAP HANA and moved to use RE2 regex now. PR size is bigger as had to change the usage of SQLWCHAR vector wherever we were creating earlier. Windows and linux checks are run here. Have verified on windows third party tools , seems working fine