fix: release builds should upload package after failing integration tests#1587
Open
sachinpro wants to merge 1 commit into
Open
fix: release builds should upload package after failing integration tests#1587sachinpro wants to merge 1 commit into
sachinpro wants to merge 1 commit into
Conversation
sachinpro
marked this pull request as ready for review
July 13, 2026 22:14
sachinpro
force-pushed
the
release_pipelines_fix
branch
from
July 14, 2026 09:40
132bb67 to
7823b39
Compare
sachinpro
force-pushed
the
release_pipelines_fix
branch
from
July 14, 2026 09:40
7823b39 to
7c7612d
Compare
logachev
reviewed
Jul 15, 2026
logachev
left a comment
logachev
left a comment
There was a problem hiding this comment.
I disagree with this PR.
-
Flaky tests. If there are flaky tests, that is concerning. With JDBC driver, I don't recall flaky tests that were not caused by the issue with the driver.
-
How can we distinguish flaky test from a regression? I don't want to relax release gates using flakiness as a justification.
-
It's ok to get a separate pipeline to manually publish a package in case we need a hotfix or any other reason, but it should be exception only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests are flaky. Release builds should upload the packages when integration tests are failing.
Successful compilation and unit tests are still a blocker.