fix(bq_driver): HTAPI fetch results fix when table is empty#1594
Open
KanchanShu wants to merge 1 commit into
Open
fix(bq_driver): HTAPI fetch results fix when table is empty#1594KanchanShu wants to merge 1 commit into
KanchanShu wants to merge 1 commit into
Conversation
shivamd-gpartner
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the HTAPI execution path for queries that return an empty result set. Previously, reaching the end of the HTAPI read stream during execution could return
SQL_NO_DATAprematurely. This change aligns HTAPI behavior with the existing non-HTAPI flow.Changes
Updated
ReadNextResultsFromStream()to:SQL_NO_DATAduring execution.Preserve
SQL_NO_DATAgeneration in the fetch path (FetchNextResultSet()), so it is returned bySQLFetch()when no rows are available.Added a test for an empty result set (
WHERE 1=2) to verify successful execution andresults.size() == 0.Behavior
Before
SQL_NO_DATAduring execution for empty result sets.After
SQLExecDirect/SQLExecutesucceeds for empty result sets.SQLFetchreturnsSQL_NO_DATAwhen no rows are available.results.size() == 0, matching the non-HTAPI behavior.