test(storage): add retry test for chunk size 0 uploads#14246
Open
cpriti-os wants to merge 2 commits intogoogleapis:mainfrom
Open
test(storage): add retry test for chunk size 0 uploads#14246cpriti-os wants to merge 2 commits intogoogleapis:mainfrom
cpriti-os wants to merge 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new retry test case for storage.objects.insert specifically targeting uploads with ChunkSize = 0. This test is designed to verify the zero-copy optimization path in gRPC and ensure that the client correctly handles retries when the internal buffer is disabled, particularly for larger objects that span multiple gRPC messages. This is a valuable addition that enhances the robustness of the retry conformance suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.