feat(bigquery): augment external data config#14397
Open
shollyman wants to merge 4 commits intogoogleapis:mainfrom
Open
feat(bigquery): augment external data config#14397shollyman wants to merge 4 commits intogoogleapis:mainfrom
shollyman wants to merge 4 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several new configuration options for BigQuery external data sources, including FileSetSpecType, JsonExtension, ObjectMetadata, and TimestampTargetPrecision. It also adds support for JsonOptions to handle character encoding for JSON data. Feedback focuses on adhering to Go naming conventions for acronyms (e.g., renaming 'Json' to 'JSON') and improving enum completeness by adding an 'Unspecified' value for FileSetSpecType.
quartzmo
approved these changes
Apr 9, 2026
Member
quartzmo
left a comment
quartzmo
left a comment
There was a problem hiding this comment.
Great to get these new fields added to the client!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for exposing additional fields present in ExternalDataConfiguration, namely controls for json handling, object metadata, and how uris are processed for some scenarios (explicit data files vs manifest files).
Testing exercises existing round tripping in unit tests, but does not introduce new integration testing.
#jetski