chore(spanner): extract ErrorDetails from grpc-status-details-bin for raw gRPC exceptions#13320
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances error detail extraction in SpannerException and SpannerExceptionFactory by supporting parsing of grpc-status-details-bin metadata from trailers. It also updates getRetryDelayInMillis, extractResourceInfo, and extractErrorInfo to leverage the centralized extractErrorDetails helper. A review comment points out a correctness bug in SpannerExceptionFactory.extractErrorDetails where the apiException parameter is completely unused, meaning error details from apiException are not extracted when cause is not a SpannerException.
sakthivelmanii
force-pushed
the
chore-spanner-error-details
branch
4 times, most recently
from
June 5, 2026 08:18
5ddfcf9 to
cabab0f
Compare
olavloite
approved these changes
Jun 5, 2026
… raw gRPC exceptions
sakthivelmanii
force-pushed
the
chore-spanner-error-details
branch
from
June 17, 2026 09:39
cabab0f to
19f63c8
Compare
lqiu96
pushed a commit
that referenced
this pull request
Jun 30, 2026
… raw gRPC exceptions (#13320)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.