chore(java-cloud-bom): migrate java-cloud-bom into monorepo#13498
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the java-cloud-bom module into the monorepo, introducing BOM configurations, validation tests, a dashboard generator, and release-note utilities. The code review identified several critical issues that need to be addressed: a missing comma in a Python list in updateREADMETable.py causing implicit string concatenation, multiple unclosed file streams in ArtifactMavenData.java and DashboardMain.java leading to resource leaks, a potential deadlock in ReleaseNoteGeneration.java when reading process streams, and missing explicit UTF-8 encoding specifications in both Java and Python file operations.
6f9b129 to
209f419
Compare
There was a problem hiding this comment.
We need to generate release note similar to https://github.com/googleapis/java-cloud-bom/releases/tag/v26.83.0. Is there anyway we can test it before merging the PR? If not, can we test it with a pre-release right after merging the PR?
Separately, we need to think about the Github release strategies. I don't think the current release process can create a separate Github release for libraries-bom.
There was a problem hiding this comment.
Thanks for the questions and feedback.
We need to generate release note similar to https://github.com/googleapis/java-cloud-bom/releases/tag/v26.83.0. Is there anyway we can test it before merging the PR? If not, can we test it with a pre-release right after merging the PR?
I'll test it with a pre-release right after merging the PR. Created b/526676540 to track this.
Separately, we need to think about the Github release strategies. I don't think the current release process can create a separate Github release for libraries-bom.
Agree. I'm thinking we could have an additional tag (e.g. libraries-bom/v26.84.0), then have GH workflow pick it up to publish the release notes. I've created b/526685922 to track this. I don't think this should be a blocker for this PR. I'll follow-up with a new PR.
2d76bff to
d280a93
Compare
0f05a1a to
7560c18
Compare
7560c18 to
d50467f
Compare
jinseopkim0
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
b690396 to
24af15b
Compare
|
jinseopkim0
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
blakeli0
left a comment
blakeli0
left a comment
There was a problem hiding this comment.
Do you mind updating the PR description regarding the high level changes?
… BOM downgrade errors
…vert slf4j-api overrides
…cross bigquery modules
…figuration changes
23f8b72 to
f51c202
Compare
…bom when generating gapic-libraries-bom/pom.xml (#6601) Exclude google-cloud-bom and libraries-bom when generating gapic-libraries-bom/pom.xml. This is needed because googleapis/google-cloud-java#13498 added new modules, among them are these two BOMs. Fixes #6600 For googleapis/google-cloud-java#13609
3 participants
b/477663818
This PR migrates the
java-cloud-bompackage (historically hosted in a separate split repository) directly into thegoogle-cloud-javamonorepo. This consolidation allows us to centrally validate, build, and publish the release BOMs (google-cloud-bomandlibraries-bom) inline with the rest of the libraries.java-cloud-bomsource modules, metadata, and tools (includingdashboard,release-note-generation, andtestssubmodules) under/java-cloud-bom.google-cloud-bomandlibraries-bom.