Skip to content

chore: expose the user set executor on TransportProvider #13557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 6 commits into from
Jun 26, 2026
Merged

chore: expose the user set executor on TransportProvider #13557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa92a9c
chore: expose user set executor on TransportProvider
igorbernstein2 Jun 25, 2026
bcb99a6
Merge branch 'main' into tp-executor
igorbernstein2 Jun 25, 2026
a9055c2
return null
igorbernstein2 Jun 26, 2026
f087d01
remove unnecessary impl
igorbernstein2 Jun 26, 2026
d0c3d6c
stray import
igorbernstein2 Jun 26, 2026
233c35a
doc
igorbernstein2 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...e/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ public boolean needsExecutor() {
return delegate.needsExecutor();
}

@Nullable
@Override
public Executor getExecutor() {
return delegate.getExecutor();
}

@Override
@Deprecated
public BigtableTransportChannelProvider withExecutor(ScheduledExecutorService executor) {
Expand Down
6 changes: 6 additions & 0 deletions ...java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,12 @@ public boolean needsExecutor() {
return executor == null;
}

@Nullable
@Override
public Executor getExecutor() {
return executor;
}

@Deprecated
@Override
public TransportChannelProvider withExecutor(ScheduledExecutorService executor) {
Expand Down
6 changes: 6 additions & 0 deletions ...pjson/src/main/java/com/google/api/gax/httpjson/InstantiatingHttpJsonChannelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ public boolean needsExecutor() {
return executor == null;
}

@Nullable
@Override
public Executor getExecutor() {
return executor;
}

@Deprecated
@Override
public TransportChannelProvider withExecutor(ScheduledExecutorService executor) {
Expand Down
10 changes: 10 additions & 0 deletions ...form-java/gax-java/gax/src/main/java/com/google/api/gax/rpc/TransportChannelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.Map;
import java.util.concurrent.Executor;
import java.util.concurrent.ScheduledExecutorService;
import javax.annotation.Nullable;

/**
* Provides an interface to either build a TransportChannel or provide a fixed TransportChannel that
Expand Down Expand Up @@ -70,6 +71,15 @@ public interface TransportChannelProvider {
@Deprecated
boolean needsExecutor();

/**
* @return the user provided executor. This can be null if the user didn't override the executor
* and/or the TransportProvider is using its internal executor.
*/
@Nullable
default Executor getExecutor() {
return null;
}

/** Sets the executor to use when constructing a new {@link TransportChannel}. */
TransportChannelProvider withExecutor(Executor executor);

Expand Down
Loading