Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2394424
feat(gapic-generator): Add Nullable annotation to generated classes
nnicolee Jun 25, 2026
0a6de10
feat: revert generator pom.xml and temp compiler dump files
nnicolee Jun 25, 2026
613d9ce
feat:update ast + glde
nnicolee Jun 25, 2026
374b0bd
feat:fixed scoping construct errors
nnicolee Jun 25, 2026
70dd1af
feat: added storage tests
nnicolee Jun 26, 2026
4bf3164
feat:added missing @Nullable and updated goldens
nnicolee Jun 26, 2026
a0cb117
feat: fixed linting
nnicolee Jun 26, 2026
6d93869
feat: updated @Nullable annotations
nnicolee Jun 29, 2026
c477dbf
updated rest of goldens + java showcase
nnicolee Jul 7, 2026
8084981
fixed linting + defined constant for nullable
nnicolee Jul 7, 2026
0f4837f
Merge branch 'main' into feat/jspecify-nullable
nnicolee Jul 9, 2026
8655411
fix: reset name in VaporReference.toBuilder()
nnicolee Jul 10, 2026
84e5843
Merge branch 'feat/jspecify-nullable' of github.com:googleapis/google…
nnicolee Jul 10, 2026
d9b3431
chore: regenerate libraries
cloud-java-bot Jul 10, 2026
9725012
fix linting on comment
nnicolee Jul 10, 2026
991c89c
Merge branch 'feat/jspecify-nullable' of github.com:googleapis/google…
nnicolee Jul 10, 2026
3783406
fix: add support for nested class in VaporReference in JavaWriterVisitor
nnicolee Jul 10, 2026
60320e7
chore: regenerate libraries
cloud-java-bot Jul 10, 2026
cf6f6a0
chore(owlbot): update toStringList removal signatures for JSpecify @N…
nnicolee Jul 13, 2026
ee95114
Merge branch 'feat/jspecify-nullable' of github.com:googleapis/google…
nnicolee Jul 13, 2026
0ec839d
Merge branch 'main' into feat/jspecify-nullable
nnicolee Jul 13, 2026
d528f65
chore: regenerate libraries
cloud-java-bot Jul 13, 2026
9abcbd5
Merge branch 'main' into feat/jspecify-nullable
nnicolee Jul 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import java.util.concurrent.TimeUnit;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
/**
Expand Down Expand Up @@ -318,7 +319,7 @@
@NullMarked
@Generated("by gapic-generator-java")
public class AccessApprovalAdminClient implements BackgroundResource {
private final AccessApprovalAdminSettings settings;
private final @Nullable AccessApprovalAdminSettings settings;
private final AccessApprovalStub stub;

/** Constructs an instance of AccessApprovalAdminClient with default settings. */
Expand Down Expand Up @@ -358,7 +359,7 @@ protected AccessApprovalAdminClient(AccessApprovalStub stub) {
this.stub = stub;
}

public final AccessApprovalAdminSettings getSettings() {
public final @Nullable AccessApprovalAdminSettings getSettings() {
return settings;
}

Expand Down Expand Up @@ -392,7 +393,7 @@ public AccessApprovalStub getStub() {
* "organizations/{organization}".
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final ListApprovalRequestsPagedResponse listApprovalRequests(FolderName parent) {
public final ListApprovalRequestsPagedResponse listApprovalRequests(@Nullable FolderName parent) {
ListApprovalRequestsMessage request =
ListApprovalRequestsMessage.newBuilder()
.setParent(parent == null ? null : parent.toString())
Expand Down Expand Up @@ -426,7 +427,8 @@ public final ListApprovalRequestsPagedResponse listApprovalRequests(FolderName p
* "organizations/{organization}".
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final ListApprovalRequestsPagedResponse listApprovalRequests(OrganizationName parent) {
public final ListApprovalRequestsPagedResponse listApprovalRequests(
@Nullable OrganizationName parent) {
ListApprovalRequestsMessage request =
ListApprovalRequestsMessage.newBuilder()
.setParent(parent == null ? null : parent.toString())
Expand Down Expand Up @@ -460,7 +462,8 @@ public final ListApprovalRequestsPagedResponse listApprovalRequests(Organization
* "organizations/{organization}".
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final ListApprovalRequestsPagedResponse listApprovalRequests(ProjectName parent) {
public final ListApprovalRequestsPagedResponse listApprovalRequests(
@Nullable ProjectName parent) {
ListApprovalRequestsMessage request =
ListApprovalRequestsMessage.newBuilder()
.setParent(parent == null ? null : parent.toString())
Expand Down Expand Up @@ -636,7 +639,7 @@ public final ListApprovalRequestsPagedResponse listApprovalRequests(
* "{projects|folders|organizations}/{id}/approvalRequests/{approval_request}"
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final ApprovalRequest getApprovalRequest(ApprovalRequestName name) {
public final ApprovalRequest getApprovalRequest(@Nullable ApprovalRequestName name) {
GetApprovalRequestMessage request =
GetApprovalRequestMessage.newBuilder()
.setName(name == null ? null : name.toString())
Expand Down Expand Up @@ -980,7 +983,8 @@ public final ApprovalRequest invalidateApprovalRequest(InvalidateApprovalRequest
* "{projects|folders|organizations}/{id}/accessApprovalSettings"
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final AccessApprovalSettings getAccessApprovalSettings(AccessApprovalSettingsName name) {
public final AccessApprovalSettings getAccessApprovalSettings(
@Nullable AccessApprovalSettingsName name) {
GetAccessApprovalSettingsMessage request =
GetAccessApprovalSettingsMessage.newBuilder()
.setName(name == null ? null : name.toString())
Expand Down Expand Up @@ -1204,7 +1208,7 @@ public final AccessApprovalSettings updateAccessApprovalSettings(
* @param name Name of the AccessApprovalSettings to delete.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final void deleteAccessApprovalSettings(AccessApprovalSettingsName name) {
public final void deleteAccessApprovalSettings(@Nullable AccessApprovalSettingsName name) {
DeleteAccessApprovalSettingsMessage request =
DeleteAccessApprovalSettingsMessage.newBuilder()
.setName(name == null ? null : name.toString())
Expand Down Expand Up @@ -1457,9 +1461,10 @@ public static class ListApprovalRequestsPage
ListApprovalRequestsPage> {

private ListApprovalRequestsPage(
PageContext<ListApprovalRequestsMessage, ListApprovalRequestsResponse, ApprovalRequest>
@Nullable
PageContext<ListApprovalRequestsMessage, ListApprovalRequestsResponse, ApprovalRequest>
context,
ListApprovalRequestsResponse response) {
@Nullable ListApprovalRequestsResponse response) {
super(context, response);
}

Expand All @@ -1469,15 +1474,17 @@ private static ListApprovalRequestsPage createEmptyPage() {

@Override
protected ListApprovalRequestsPage createPage(
PageContext<ListApprovalRequestsMessage, ListApprovalRequestsResponse, ApprovalRequest>
@Nullable
PageContext<ListApprovalRequestsMessage, ListApprovalRequestsResponse, ApprovalRequest>
context,
ListApprovalRequestsResponse response) {
@Nullable ListApprovalRequestsResponse response) {
return new ListApprovalRequestsPage(context, response);
}

@Override
public ApiFuture<ListApprovalRequestsPage> createPageAsync(
PageContext<ListApprovalRequestsMessage, ListApprovalRequestsResponse, ApprovalRequest>
@Nullable
PageContext<ListApprovalRequestsMessage, ListApprovalRequestsResponse, ApprovalRequest>
context,
ApiFuture<ListApprovalRequestsResponse> futureResponse) {
return super.createPageAsync(context, futureResponse);
Expand All @@ -1493,7 +1500,7 @@ public static class ListApprovalRequestsFixedSizeCollection
ListApprovalRequestsFixedSizeCollection> {

private ListApprovalRequestsFixedSizeCollection(
List<ListApprovalRequestsPage> pages, int collectionSize) {
@Nullable List<ListApprovalRequestsPage> pages, int collectionSize) {
super(pages, collectionSize);
}

Expand All @@ -1503,7 +1510,7 @@ private static ListApprovalRequestsFixedSizeCollection createEmptyCollection() {

@Override
protected ListApprovalRequestsFixedSizeCollection createCollection(
List<ListApprovalRequestsPage> pages, int collectionSize) {
@Nullable List<ListApprovalRequestsPage> pages, int collectionSize) {
return new ListApprovalRequestsFixedSizeCollection(pages, collectionSize);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.List;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
/**
Expand Down Expand Up @@ -207,7 +208,7 @@ public static Builder newHttpJsonBuilder() {
}

/** Returns a new builder for this class. */
public static Builder newBuilder(ClientContext clientContext) {
public static Builder newBuilder(@Nullable ClientContext clientContext) {
return new Builder(clientContext);
}

Expand All @@ -227,7 +228,7 @@ protected Builder() throws IOException {
this(((ClientContext) null));
}

protected Builder(ClientContext clientContext) {
protected Builder(@Nullable ClientContext clientContext) {
super(AccessApprovalStubSettings.newBuilder(clientContext));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
import java.util.List;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
/**
Expand Down Expand Up @@ -371,7 +372,7 @@ public static Builder newHttpJsonBuilder() {
}

/** Returns a new builder for this class. */
public static Builder newBuilder(ClientContext clientContext) {
public static Builder newBuilder(@Nullable ClientContext clientContext) {
return new Builder(clientContext);
}

Expand Down Expand Up @@ -481,7 +482,7 @@ protected Builder() {
this(((ClientContext) null));
}

protected Builder(ClientContext clientContext) {
protected Builder(@Nullable ClientContext clientContext) {
super(clientContext);

listApprovalRequestsSettings =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.util.Objects;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
@NullMarked
Expand Down Expand Up @@ -137,7 +138,7 @@ public static String formatOrganizationName(String organization) {
return newOrganizationBuilder().setOrganization(organization).build().toString();
}

public static AccessApprovalSettingsName parse(String formattedString) {
public static @Nullable AccessApprovalSettingsName parse(String formattedString) {
if (formattedString.isEmpty()) {
return null;
}
Expand All @@ -163,7 +164,7 @@ public static List<AccessApprovalSettingsName> parseList(List<String> formattedS
return list;
}

public static List<String> toStringList(List<AccessApprovalSettingsName> values) {
public static List<String> toStringList(List<@Nullable AccessApprovalSettingsName> values) {
List<String> list = new ArrayList<>(values.size());
for (AccessApprovalSettingsName value : values) {
if (value == null) {
Expand Down Expand Up @@ -213,7 +214,7 @@ public String toString() {
}

@Override
public boolean equals(Object o) {
public boolean equals(@Nullable Object o) {
if (o == this) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.util.Objects;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
@NullMarked
Expand Down Expand Up @@ -166,7 +167,7 @@ public static String formatOrganizationApprovalRequestName(
.toString();
}

public static ApprovalRequestName parse(String formattedString) {
public static @Nullable ApprovalRequestName parse(String formattedString) {
if (formattedString.isEmpty()) {
return null;
}
Expand All @@ -193,7 +194,7 @@ public static List<ApprovalRequestName> parseList(List<String> formattedStrings)
return list;
}

public static List<String> toStringList(List<ApprovalRequestName> values) {
public static List<String> toStringList(List<@Nullable ApprovalRequestName> values) {
List<String> list = new ArrayList<>(values.size());
for (ApprovalRequestName value : values) {
if (value == null) {
Expand Down Expand Up @@ -246,7 +247,7 @@ public String toString() {
}

@Override
public boolean equals(Object o) {
public boolean equals(@Nullable Object o) {
if (o == this) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Objects;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
@NullMarked
Expand Down Expand Up @@ -65,7 +66,7 @@ public static String format(String folder) {
return newBuilder().setFolder(folder).build().toString();
}

public static FolderName parse(String formattedString) {
public static @Nullable FolderName parse(String formattedString) {
if (formattedString.isEmpty()) {
return null;
}
Expand All @@ -83,7 +84,7 @@ public static List<FolderName> parseList(List<String> formattedStrings) {
return list;
}

public static List<String> toStringList(List<FolderName> values) {
public static List<String> toStringList(List<@Nullable FolderName> values) {
List<String> list = new ArrayList<>(values.size());
for (FolderName value : values) {
if (value == null) {
Expand Down Expand Up @@ -125,7 +126,7 @@ public String toString() {
}

@Override
public boolean equals(Object o) {
public boolean equals(@Nullable Object o) {
if (o == this) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Objects;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
@NullMarked
Expand Down Expand Up @@ -65,7 +66,7 @@ public static String format(String organization) {
return newBuilder().setOrganization(organization).build().toString();
}

public static OrganizationName parse(String formattedString) {
public static @Nullable OrganizationName parse(String formattedString) {
if (formattedString.isEmpty()) {
return null;
}
Expand All @@ -83,7 +84,7 @@ public static List<OrganizationName> parseList(List<String> formattedStrings) {
return list;
}

public static List<String> toStringList(List<OrganizationName> values) {
public static List<String> toStringList(List<@Nullable OrganizationName> values) {
List<String> list = new ArrayList<>(values.size());
for (OrganizationName value : values) {
if (value == null) {
Expand Down Expand Up @@ -125,7 +126,7 @@ public String toString() {
}

@Override
public boolean equals(Object o) {
public boolean equals(@Nullable Object o) {
if (o == this) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Objects;
import javax.annotation.Generated;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

// AUTO-GENERATED DOCUMENTATION AND CLASS.
@NullMarked
Expand Down Expand Up @@ -65,7 +66,7 @@ public static String format(String project) {
return newBuilder().setProject(project).build().toString();
}

public static ProjectName parse(String formattedString) {
public static @Nullable ProjectName parse(String formattedString) {
if (formattedString.isEmpty()) {
return null;
}
Expand All @@ -83,7 +84,7 @@ public static List<ProjectName> parseList(List<String> formattedStrings) {
return list;
}

public static List<String> toStringList(List<ProjectName> values) {
public static List<String> toStringList(List<@Nullable ProjectName> values) {
List<String> list = new ArrayList<>(values.size());
for (ProjectName value : values) {
if (value == null) {
Expand Down Expand Up @@ -125,7 +126,7 @@ public String toString() {
}

@Override
public boolean equals(Object o) {
public boolean equals(@Nullable Object o) {
if (o == this) {
return true;
}
Expand Down
Loading
Loading