chore(deps): align logback versions in google-cloud-jar-parent #13678
Conversation
Align `logback-classic` and `logback-core` to `1.5.33` in `google-cloud-jar-parent` to fix the version mismatch on Java 11+. Remove local `logback-classic` override from `google-cloud-storage` to inherit the aligned version. Add a `java8-logback` profile in `java-storage/pom.xml` to manage both logback dependencies to `1.3.16` when running in a Java 8 environment, maintaining test compatibility. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Logback dependency to version 1.5.33 in the parent POM and removes the hardcoded version from the Google Cloud Storage POM. Additionally, it introduces a Maven profile to automatically downgrade Logback to version 1.3.16 when running in a Java 8 environment, ensuring compatibility since Logback 1.5.x requires Java 11 or higher. I have no feedback to provide.
There was a problem hiding this comment.
Would it make sense to put this in google-cloud-jar-parent/pom.xml? Would other modules need this as well?
There was a problem hiding this comment.
I was looking at all the other modules and I don't see them managing their own version of logback-classic. I don't think it makes sense for storage to do it, but they may have some historical reason so I've kept it just for them.
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lqiu96
changed the title
3 participants
Align
logback-classicandlogback-coreto1.5.33ingoogle-cloud-jar-parentto fix the version mismatch on Java 11+. Remove locallogback-classicoverride fromgoogle-cloud-storageto inherit the aligned version.Add a
java8-logbackprofile injava-storage/pom.xmlto manage both logback dependencies to1.3.16when running in a Java 8 environment, maintaining test compatibility.