chore: declare jspecify in jar parent and ignore if unused#13704
Merged
Conversation
Declare org.jspecify:jspecify as a dependency in google-cloud-jar-parent so that all client libraries inherit it, resolving "used undeclared dependency" issues caused by the new gapic-generator-java JSpecify onboarding. Also add org.jspecify:jspecify to ignoredUnusedDeclaredDependencies in java-shared-config to prevent "unused declared dependency" warnings/failures in modules that do not use it yet. TAG=agy CONV=d6bb9d61-0aa4-4d9f-af2b-ce10da21c3bd
lqiu96
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the org.jspecify:jspecify dependency to the parent POM (google-cloud-jar-parent/pom.xml) and configures it as an ignored unused declared dependency in the shared configuration POM (java-shared-config/java-shared-config/pom.xml). There are no review comments, and I have no feedback to provide.
Update parent POMs that override ignoredUnusedDeclaredDependencies to explicitly include org.jspecify:jspecify. This prevents "unused declared dependency" failures in submodules (like grpc-* modules) that inherit JSpecify from google-cloud-jar-parent but do not use it, when their parent POM overrides the global ignore list defined in java-shared-config. TAG=agy CONV=d6bb9d61-0aa4-4d9f-af2b-ce10da21c3bd
nnicolee
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare org.jspecify:jspecify as a dependency in google-cloud-jar-parent so that all client libraries inherit it, resolving "used undeclared dependency" issues caused by the new JSpecify changes.
Also add org.jspecify:jspecify to ignoredUnusedDeclaredDependencies in java-shared-config to prevent "unused declared dependency" warnings/failures in modules that do not use it yet (e.g. gRPC modules)