Skip to content

chore: add protoc to tool section#13709

Merged
JoeWang1127 merged 4 commits into
googleapis:mainfrom
JoeWang1127:chore/add-protoc-2
Jul 8, 2026
Merged

chore: add protoc to tool section#13709
JoeWang1127 merged 4 commits into
googleapis:mainfrom
JoeWang1127:chore/add-protoc-2

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Add protoc to tool section in librarian.yaml.

Locally tested librarian install and librarian generate apphub, the protoc binary is from the librarian managed directory:

((.venv) ) joewa@joewa-glinux-medium:~/workspace/google-cloud-java$ go run github.com/googleapis/librarian/cmd/librarian@${V} generate apphub -v
/usr/local/google/home/joewa/.cache/librarian/bin/protoc/v33.2/bin/protoc --experimental_allow_proto3_optional ...

Fixes googleapis/librarian#6708

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the 'protoc' tool configuration to 'librarian.yaml'. However, the tool was added as a direct map key instead of a list item under 'tools', which breaks the expected YAML structure. A correction has been suggested to format 'protoc' as a list item.

Comment thread librarian.yaml
@JoeWang1127
JoeWang1127 marked this pull request as ready for review July 8, 2026 21:07
@JoeWang1127
JoeWang1127 requested review from a team as code owners July 8, 2026 21:07
@JoeWang1127
JoeWang1127 requested a review from zhumin8 July 8, 2026 21:07
@JoeWang1127
JoeWang1127 merged commit 087ea90 into googleapis:main Jul 8, 2026
201 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-java: add protoc to tool section in librarian.yaml

2 participants