ci(showcase): use separate filter job for version check#13770
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
lqiu96
marked this pull request as ready for review
July 14, 2026 17:34
lqiu96
enabled auto-merge (squash)
July 14, 2026 17:35
blakeli0
approved these changes
Jul 14, 2026
blakeli0
left a comment
blakeli0
left a comment
Contributor
There was a problem hiding this comment.
Does this check have to be required? @zhumin8
Separately, can we use one version as source of truth? It seems that we have a showcase version in pom and a showcase commitish in librarian.yaml. This could cause inconsistency if they are not in sync.
Contributor
Exactly why we need this test (for now).
Sure. It be great if the showcase version in pom can source from librarian.yaml and keep that as source of truth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check-versionjob in showcase is not running in PRs that do not modify the specific paths. Update the job to use a filter job to skip the job on non-relevant PRs.Example: #13558