fix(bigquery-jdbc): refine temporal timezone coercion and PreparedStatement parameter setters#13813
Merged
Conversation
…tement parameter setters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements several JDBC features in BigQueryPreparedStatement, including support for Java 8 date/time types in setObject, Calendar overloads for setting dates, times, and timestamps, and metadata retrieval methods (getParameterMetaData and getMetaData). The feedback suggests refactoring convertTimeWithCalendar to use the modern java.time API to avoid legacy Calendar manipulation and preserve millisecond precision. Additionally, it is recommended to deduplicate the temporal type checks in setObject overloads into a helper method and remove unused dead code like convertDateToCalendar and getSafeCalendar.
…PreparedStatement
…ndler null check in getParameterClassName
logachev
approved these changes
Jul 20, 2026
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/535194644
Calendartimezone conversions inBigQueryTypeCoercionUtilityusingjava.timeAPIs.setTemporalObjecthelper to eliminate duplicate temporal type logic acrosssetObjectoverloads.Calendarsetters and replaced silent stubs withBigQueryJdbcSqlFeatureNotSupportedException.