test(storage-nio): disable copying annotations for storage-nio#13830
Merged
Conversation
nnicolee
marked this pull request as ready for review
July 20, 2026 04:47
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test cases in CloudStorageIsDirectoryTest.java to mock the Page class without annotations using Mockito.mock(Page.class, Mockito.withSettings().withoutAnnotations()) instead of a simple mock. There are no review comments, and I have no additional feedback to provide.
ShreyasSinha
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JSpecify 1.0.0, the
@NullMarkedannotation includesElementType.MODULEin its@Targetmetadata. BecauseElementType.MODULEwas introduced in Java 9, reflecting on@NullMarkedclasses under Java 8 (JDK 1.8) throwsEnumConstantNotPresentExceptionProxywrapped in anArrayStoreException.When unit tests run on Java 8, Mockito's default mock generation (via ByteBuddy) attempts to copy all runtime class annotations from target classes onto mock subclasses. This triggers the reflection crash when mocking
Pageclasses that are transitively annotated with@NullMarked.To bypass this Java 8 limitation:
Pageclasses withMockito.mock(Page.class, Mockito.withSettings().withoutAnnotations())inCloudStorageIsDirectoryTest.Class.getAnnotations()on the target class during proxy creation, allowing tests to run and mock stubs successfully on Java 8 pipelines.Modified Mockito mock setups in:
CloudStorageIsDirectoryTest