test(bigtable): disable deep stub answers causing Java 8 Mockito reflection crash#13831
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused org.mockito.Answers import and simplifies several @Mock annotations in BigtableDataClientTests.java by removing the (answer = Answers.RETURNS_DEEP_STUBS) configuration. There are no review comments to address, so no additional feedback is provided.
sonykhan120595-dotcom
approved these changes
Jul 20, 2026
nnicolee
marked this pull request as ready for review
July 20, 2026 14:42
mutianf
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In JSpecify 1.0.0, the
@NullMarkedannotation targetsElementType.MODULE. BecauseElementType.MODULEwas introduced in Java 9, reflecting on@NullMarkedclasses under Java 8 (JDK 1.8) throwsEnumConstantNotPresentExceptionProxywrapped in anArrayStoreException.In
BigtableDataClientTests, Mockito's mock declarations forServerStreamingCallablewere configured withanswer = Answers.RETURNS_DEEP_STUBS. When Mockito generates deep stubs, it dynamically reflects on the return type to build intermediate mocks, triggering this reflection crash on@NullMarkedclasses under Java 8 CI pipelines.Solution
Since the tests do not actually call or rely on deep stubs for these streaming callables, we can safely remove
(answer = Answers.RETURNS_DEEP_STUBS). Removing deep stubs prevents Mockito from performing the reflection that causes the Java 8 pipeline crash, allowing the test suite to execute successfully.