feat(storage): allow checksum on appendable upload finalization#13833
Open
Dhriti07 wants to merge 9 commits into
Open
feat(storage): allow checksum on appendable upload finalization#13833Dhriti07 wants to merge 9 commits into
Dhriti07 wants to merge 9 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for validating the final object's CRC32c checksum during appendable uploads by allowing an expected CRC32c string to be passed to the finalization and close methods. The feedback highlights a logic bug in BlobAppendableUploadImpl.close where passing a null checksum when finalizeOnClose is false incorrectly throws an exception, and recommends adding @Nullable annotations to the new parameters across the API and implementation classes to improve static analysis and consistency.
Dhriti07
force-pushed
the
fix-takeover-checksum-validation
branch
from
July 20, 2026 10:03
20b4818 to
55c0329
Compare
Dhriti07
force-pushed
the
fix-takeover-checksum-validation
branch
from
July 20, 2026 10:05
55c0329 to
14fda1b
Compare
Dhriti07
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Dhriti07
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow checksum on appendable upload finalization