chore(spanner): remove deprecated OTel GCP resource detector dependency#13843
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the dependency on com.google.cloud.opentelemetry:detector-resources-support with io.opentelemetry.contrib:opentelemetry-gcp-resources in pom.xml. Consequently, BuiltInMetricsProvider.java has been updated to use GCPResourceProvider instead of GCPPlatformDetector to detect the client's GCP location, retrieving attributes like cloud.region and cloud.availability_zone instead of the older custom keys. There are no review comments, and I have no additional feedback to provide.
f368e48 to
65c2ed6
Compare
65c2ed6 to
934716d
Compare
| <artifactId>opentelemetry-sdk-metrics</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.cloud.opentelemetry</groupId> |
There was a problem hiding this comment.
Also this was highlighted from Otel team.
cc: @psx95
There was a problem hiding this comment.
Yes, it is preferred to remove dependency from this exporter. The recommendation is to move to the standard OpenTelemetry OTLP exporters.
4 participants
No description provided.