Skip to content

deps(shared-deps): switch conscrypt shared dependency to conscrypt-openjdk-uber#13845

Merged
lqiu96 merged 1 commit into
mainfrom
shared-deps-conscrypt-uber
Jul 21, 2026
Merged

deps(shared-deps): switch conscrypt shared dependency to conscrypt-openjdk-uber#13845
lqiu96 merged 1 commit into
mainfrom
shared-deps-conscrypt-uber

Conversation

@lqiu96

@lqiu96 lqiu96 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Bundle the uber jar which contains pre-compiled native BoringSSL binaries for all major platforms. Allows users to easily use Conscrypt without any need for platform detectors or any configuration steps on their machines.

Follows the pattern of grpc-netty-shaded which also bundles the binaries for major platforms

@lqiu96
lqiu96 requested a review from blakeli0 July 21, 2026 16:31
@lqiu96
lqiu96 requested review from a team as code owners July 21, 2026 16:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the conscrypt dependency from conscrypt-openjdk to conscrypt-openjdk-uber in both dependencies.txt and the third-party dependencies pom.xml. There are no review comments, and I have no feedback to provide.

<dependency>
<groupId>org.conscrypt</groupId>
<artifactId>conscrypt-openjdk</artifactId>
<artifactId>conscrypt-openjdk-uber</artifactId>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the dependency tree of the uber jar look like?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[INFO] --- dependency:3.7.0:tree (default-cli) @ Testing ---
[INFO] org.example:Testing:jar:1.0-SNAPSHOT
[INFO] \- org.conscrypt:conscrypt-openjdk-uber:jar:2.6.0:compile

Doesn't seem like it has any dependencies. Jar size is larger now because it holds binaries for multiple platforms as well as the Java code

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2026
@lqiu96
lqiu96 enabled auto-merge (squash) July 21, 2026 17:26
@lqiu96
lqiu96 merged commit 2e3f208 into main Jul 21, 2026
291 of 296 checks passed
@lqiu96
lqiu96 deleted the shared-deps-conscrypt-uber branch July 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants