Skip to content

fix: fix session budget penalty logic #13857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mutianf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix session budget penalty logic #13857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...c/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionCreationBudget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.time.Duration;
import java.time.Instant;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.logging.Level;
Expand Down Expand Up @@ -63,7 +64,7 @@ Instant getNextAvailableBudget() {
return Instant.now();
}

return delayedCreationTokens.get(0);
return Collections.min(delayedCreationTokens);

@gemini-code-assist gemini-code-assist Bot Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While Collections.min() correctly finds the earliest timestamp, it has a time complexity of O(N) for a List, where N can be up to maxConcurrentRequests (default 1000). This could become a performance bottleneck if getNextAvailableBudget() is called frequently.

Consider using a java.util.PriorityQueue for delayedCreationTokens. This would make getNextAvailableBudget() an O(1) operation (peek()), and addCreationFailure() an O(log N) operation. drainCreationFailures() could also be implemented more efficiently by repeatedly polling expired items from the head of the queue (O(k*logN) where k is the number of expired items).

}

boolean tryReserveSession() {
Expand Down Expand Up @@ -96,10 +97,6 @@ private void drainCreationFailures() {
if (iter.next().isBefore(now)) {
concurrentRequests--;
iter.remove();
} else {
// The list should be roughly sorted. Exit early when we encounter
// something expires later.
break;
}
}
}
Expand Down
Loading