fix(bigtable): stop installing DirectpathEnforcer on the directpath pool#13880
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request temporarily disables the DirectpathEnforcer in SwitchingChannelPool when configuring the primary channel pool in DIRECT_ACCESS_WITH_FALLBACK mode. This workaround prevents VMs from becoming indefinitely wedged when negotiating non-ALTS connections, pending a more robust fix in FallbackChannelPool. The reviewer suggested adding a tracking issue or ticket reference to the temporary TODO comment to ensure it is tracked and resolved, in line with standard style guidelines.
| new DirectpathEnforcer( | ||
| "Non-directpath connections are not allowed in the directpath channel " | ||
| + "pool when a fallback channel pool is available.")); | ||
| // TODO: temporarily NOT installing the DirectpathEnforcer. |
There was a problem hiding this comment.
When adding a temporary TODO comment, it is best practice to include a tracking issue or ticket reference. This ensures that the temporary workaround is tracked and eventually resolved, preventing it from becoming permanent technical debt.
| // TODO: temporarily NOT installing the DirectpathEnforcer. | |
| // TODO(issue-number): temporarily NOT installing the DirectpathEnforcer. |
References
- According to the Google Java Style Guide (Section 4.8.6.2), TODO comments should include an identifier (such as a bug tracker reference or username) to provide context and ensure traceability. (link)
2 participants
No description provided.