Skip to content

fix(spanner): Fix the start timestamp > end timestamp issue for change stream initial query. #13885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiangzzhu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(spanner): Fix the start timestamp > end timestamp issue for change stream initial query. #13885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ...spanner-executor/src/main/java/com/google/cloud/executor/spanner/CloudClientExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2462,14 +2462,10 @@ private Status executeExecuteChangeStreamQuery(
// For initial partition query (no partition token) we simulate precision of the timestamp
// in nanoseconds as that's closer inlined with the production client code.

String startTime =
timestampToString(
!action.hasPartitionToken(), Timestamps.toMicros(action.getStartTime()));
String startTime = timestampToString(false, Timestamps.toMicros(action.getStartTime()));
String endTime = "null";
if (action.hasEndTime()) {
endTime =
timestampToString(
!action.hasPartitionToken(), Timestamps.toMicros(action.getEndTime()));
endTime = timestampToString(false, Timestamps.toMicros(action.getEndTime()));
}
String heartbeat = "null";
if (action.hasHeartbeatMilliseconds()) {
Expand Down
Loading