Skip to content

fix(bigquery-jdbc): Add PerConnectionHandler to list of excempted logging classes #13888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neenu1995 merged 2 commits into from
Jul 24, 2026
+25 −0
Merged

fix(bigquery-jdbc): Add PerConnectionHandler to list of excempted logging classes #13888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a6507
fix(bigquery-jdbc): Add PerConnectionHandler to list of excempted log…
Neenu1995 Jul 24, 2026
d1ad9e0
lint
Neenu1995 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcCustomLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ private static boolean isLoggerClass(String className) {
return className.equals("com.google.cloud.bigquery.jdbc.BigQueryJdbcCustomLogger")
|| className.equals("com.google.cloud.bigquery.jdbc.BigQueryJdbcResultSetLogger")
|| className.startsWith("com.google.cloud.bigquery.jdbc.BigQueryJdbcRootLogger")
|| className.equals("com.google.cloud.bigquery.jdbc.PerConnectionFileHandler")
Comment thread
Neenu1995 marked this conversation as resolved.
|| className.equals(BigQueryJdbcLogRecord.class.getName());
}
}
Expand Down
24 changes: 24 additions & 0 deletions ...query-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcCustomLoggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import com.google.cloud.bigquery.FieldValue.Attribute;
import com.google.cloud.bigquery.FieldValueList;
import com.google.cloud.bigquery.LegacySQLTypeName;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
Expand All @@ -41,6 +42,7 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

public class BigQueryJdbcCustomLoggerTest extends BigQueryJdbcLoggingBaseTest {

Expand Down Expand Up @@ -118,6 +120,28 @@ public void testLazyCallerInference() {
assertEquals("testLazyCallerInference", methodName);
}

@Test
public void testCallerInferenceWithPerConnectionFileHandler(@TempDir Path tempDir) {
PerConnectionFileHandler perConnHandler =
new PerConnectionFileHandler(tempDir.toString(), Level.ALL);
try {
logger.fine("Message through PerConnectionFileHandler");

List<LogRecord> records = testHandler.getRecords();
assertEquals(1, records.size());
LogRecord record = records.get(0);

// Publish record via PerConnectionFileHandler to put PerConnectionFileHandler on stack trace
perConnHandler.publish(record);

// Verify that caller inference skips PerConnectionFileHandler frame
assertEquals(BigQueryJdbcCustomLoggerTest.class.getName(), record.getSourceClassName());
assertEquals("testCallerInferenceWithPerConnectionFileHandler", record.getSourceMethodName());
} finally {
perConnHandler.close();
}
}

@Test
public void testHotPathLoggerLogToDefaultWhenContextIsNull() {
BigQueryJdbcCustomLogger hotpathLogger =
Expand Down
Loading