ci(bom): print full mvn-install.log on pre-install failure#13891
Merged
Conversation
lqiu96
changed the title
lqiu96
force-pushed
the
fix-preinstall-logging
branch
from
July 24, 2026 19:11
337c5b4 to
28980cb
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Guava dependency version from 33.5.0-jre to 33.6.0-jre across multiple pom.xml files. Additionally, it modifies the pre-install.sh test script to print the entire mvn-install.log file using cat instead of just the last 200 lines using tail when a Maven installation fails. There are no review comments, so I have no feedback to provide.
|
|
lqiu96
enabled auto-merge (squash)
July 24, 2026 19:33
jinseopkim0
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
java-cloud-bom/tests/pre-install.shto print the completemvn-install.logon failure instead of truncating output withtail -n 200.Rationale
When a module fails compilation during
pre-install.sh, Maven skips installing its JAR into local cache (~/.m2/repository). Downstream modules subsequently fail dependency resolution when attempting to fetch missing in-repo SNAPSHOT artifacts from Maven Central.Because
pre-install.shpreviously rantail -n 200, only the trailing downstream dependency resolution errors were printed in CI, concealing the actual root-cause compilation errors that occurred earlier in the log.