fix: fix java-cloud-bom README update workflow after monorepo migration#13892
Open
suztomo wants to merge 6 commits into
Open
fix: fix java-cloud-bom README update workflow after monorepo migration#13892suztomo wants to merge 6 commits into
suztomo wants to merge 6 commits into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/537369259
Context
After the monorepo migration (PR #13498), the
java-cloud-bomrepository was moved into thejava-cloud-bom/subdirectory. The GitHub Actions workflow.github/workflows/java-cloud-bom-update-readme-table.yamlwas copied over from the split repository without updating its paths or filter triggers.Root Causes
releaseevent,dorny/paths-filtercompares the release tag commit againstmain. Since release commits are already merged tomainprior to tagging, the diff is empty, causingdorny/paths-filterto evaluate tofalseand skip theupdate-readmejob.python libraries-bom-table-generation/updateREADMETable.pyfrom the repository root, but both the script and targetREADME.mdare located within thejava-cloud-bom/subdirectory.Fix
filterjob: Replaced it with a direct job condition:libraries-bom/v*) used bycreate_additional_release_tag.yamlandjava-cloud-bom-release-note-generation.yaml.defaults.run.working-directory: java-cloud-bomto theupdate-readmejob so all steps execute insidejava-cloud-bom/.