chore: consolidate prettierignore and prettierrc files: autogen#8082
chore: consolidate prettierignore and prettierrc files: autogen#8082
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Prettier configuration, adds gts as a development dependency, and updates a test assertion in the processing package. The most significant change is the addition of the build/protos directory to the files array in numerous package.json files across the monorepo to ensure these files are included in published packages. Feedback focuses on improving the consistency of the files array ordering across packages and removing a duplicate entry found in the google-cloud-translate configuration.
feywind
force-pushed
the
feywind-gh4581-prettier-ag
branch
from
c85a8f5 to
e5c9d30
Compare
feywind
force-pushed
the
feywind-gh4581-prettier-ag
branch
from
e5c9d30 to
ce2d909
Compare
…eapis/google-cloud-node into feywind-gh4581-prettier-ag
…eapis/google-cloud-node into feywind-gh4581-prettier-ag
…eapis/google-cloud-node into feywind-gh4581-prettier-ag
…m/googleapis/google-cloud-node into feywind-gh4581-prettier-ag
…d-gh4581-prettier-ag
|
Do we need to update the generator as well to stop automatically producing these? Is that in a separate PR? |
There was a problem hiding this comment.
Do we need this change? Can we remove it?
There was a problem hiding this comment.
These changes (the exitCode and the \* in the other file) were both hard errors on the linter when running through the CI. They're sensible changes anyway, so I am okay with going ahead with them. I'm not sure why they're only on storage-control, but this library is fairly old, so it might've predated the harmonization efforts.
There was a problem hiding this comment.
Was this change made by running the formatter?
It looks like I filtered that out in this PR, but it might be best to do it separately anyway. |
|
2 participants
Split from #7948 to handle just autogen library changes.
Regarding: googleapis/librarian#4581