Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 16, 2026

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8

…prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8
@parthea parthea requested review from a team as code owners January 16, 2026 23:09
@parthea parthea requested a review from suzmue January 16, 2026 23:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintenance and modernization across several Google Cloud client libraries. It updates a core librarian image, refactors authentication logic for improved clarity and directness, and upgrades the Python version used for static type analysis. Additionally, it includes minor dependency cleanups to optimize the development environment.

Highlights

  • Librarian Image Update: The python-librarian-generator image has been updated to a new SHA256 hash, ensuring the use of the latest version of the librarian tool.
  • Authentication Scope Handling Refactoring: Numerous base.py transport files across various Google Cloud client libraries have been refactored to directly pass authentication scopes and other credentials-related arguments, removing an intermediate scopes_kwargs dictionary.
  • Python Version Upgrade for Type Checking: The mypy.ini configuration files in several packages have been updated to specify python_version = 3.14, indicating an upgrade in the Python version used for type checking.
  • Dependency Cleanup: The noxfile.py for google-cloud-bigquery-storage has been updated to remove cachetools and cryptography from its test dependencies, streamlining the build process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the librarian generator image and applies the resulting code changes. The changes include refactoring how authentication scopes are passed in transport layers, which improves code clarity. However, the python_version in numerous mypy.ini files has been updated to 3.14, which is not a valid Python version and will likely break static analysis. This should be corrected to a supported version.

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The specified Python version 3.14 is not a valid released version and is not yet supported by mypy. This will likely cause errors in the static analysis check. Please use a valid and supported Python version, such as 3.12.

python_version = 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant