Skip to content

feat: regenerate monitoring using generator v1.32.0#17165

Open
chalmerlowe wants to merge 3 commits into
mainfrom
fix-monitoring-FTL-1.32.0
Open

feat: regenerate monitoring using generator v1.32.0#17165
chalmerlowe wants to merge 3 commits into
mainfrom
fix-monitoring-FTL-1.32.0

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe commented May 18, 2026

Updates post processing to account for dropping support for Python 3.7, 3.8, 3.9 and impacts that has on using 3.10 for lower bounds testing.

Changes:

  • Adds pandas and numpy to constraints-3.10.txt and installs pandas extra in prerelease_deps and core_deps_from_source nox sessions.
  • Updates pandas dependency lower bound to 1.3.4 and updates constraints-3.10.txt to use pandas 1.3.4 and numpy 1.21.3 to avoid pip build errors on Python 3.10.

Partially corrects #17153 🦕

Regenerates google-cloud-monitoring library using gapic-generator v1.32.0.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.9, updating the package to require Python 3.10 or higher. Key changes include updating dependency lower bounds for google-api-core and grpcio, removing legacy compatibility code for older Python versions, and updating copyright headers to 2026. Feedback from the reviewer highlights a discrepancy in the google-auth version bump relative to the PR description, formatting regressions in docstrings, and the removal of the 'warnings as errors' flag in documentation builds.

Comment thread packages/google-cloud-monitoring/setup.py
Comment thread packages/google-cloud-monitoring/testing/constraints-3.10.txt
Comment thread packages/google-cloud-monitoring/noxfile.py
…itoring

Add pandas and numpy to constraints-3.10.txt and install pandas extra in prerelease_deps and core_deps_from_source nox sessions.
Update pandas dependency lower bound to 1.3.4 and constraints to use pandas 1.3.4 and numpy 1.21.3 to avoid pip build errors on Python 3.10 in CI/CD.
@chalmerlowe chalmerlowe marked this pull request as ready for review May 18, 2026 12:24
@chalmerlowe chalmerlowe requested review from a team as code owners May 18, 2026 12:24
resource types, only the monitored resource
types for which the metric type has recent
data will be included in the returned
data will be included in the returned
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to take a look at the extra whitespace being added here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented off-line in chat.

@chalmerlowe chalmerlowe added this to the generate via 1.32.0 milestone May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants