Skip to content

feat(pubsub): regenerate pubsub library using gapic-generator v1.32.0#17167

Merged
chalmerlowe merged 1 commit into
mainfrom
fix-pubsub-FTL-1.32.0
May 19, 2026
Merged

feat(pubsub): regenerate pubsub library using gapic-generator v1.32.0#17167
chalmerlowe merged 1 commit into
mainfrom
fix-pubsub-FTL-1.32.0

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe commented May 18, 2026

Updates post processing to account for dropping support for Python 3.7, 3.8, 3.9 and impacts that has on using 3.10 for lower bounds testing.

Changes:

  • adds grpcio-status, opentelemetry-api, opentelemetry-sdk to constraints-3.10.txt and installs pandas extra in prerelease_deps and core_deps_from_source nox sessions.
  • updates dependency versions in constraints-3.10.txt to match expectations in the setup.py file.
  • Refined post-processing replacement rules in ``librarian/generator-input/client-post-processing/pubsub-integration.yaml` to make these dependency and constraint alignments.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on dropping support for Python 3.9, updating the minimum required version to 3.10, and increasing the lower bounds for dependencies like google-api-core and grpcio-status. It also removes legacy compatibility code for Python versions older than 3.8 and updates test assertions to be order-independent. Reviewer feedback recommends including Python 3.13 in the test matrix and package metadata to ensure consistency with dependency constraints, and suggests restoring the 'warnings as errors' flag for documentation builds to maintain quality.

Comment thread packages/google-cloud-pubsub/noxfile.py
Comment thread packages/google-cloud-pubsub/noxfile.py
Comment thread packages/google-cloud-pubsub/setup.py
@chalmerlowe chalmerlowe force-pushed the fix-pubsub-FTL-1.32.0 branch from 6fe0b3e to b9c23d9 Compare May 18, 2026 14:11
@chalmerlowe chalmerlowe added this to the generate via 1.32.0 milestone May 18, 2026
@chalmerlowe chalmerlowe marked this pull request as ready for review May 18, 2026 16:50
@chalmerlowe chalmerlowe requested review from a team as code owners May 18, 2026 16:50
@chalmerlowe chalmerlowe merged commit 01d3127 into main May 19, 2026
31 checks passed
@chalmerlowe chalmerlowe deleted the fix-pubsub-FTL-1.32.0 branch May 19, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants