-
Notifications
You must be signed in to change notification settings - Fork 566
feat(docs): Add product neutral guides #32256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aandreassa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bshaffer. Looks great overall, I just think it is best without the PHP comparison text
help/CLIENT_CONFIGURATION.md
Outdated
|
|
||
| ## 5. Configuring Retries and Timeouts | ||
|
|
||
| Ruby uses **Seconds** (Float/Integer) for time values, whereas PHP uses Milliseconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest we remove the comparisons to PHP.
help/CLIENT_CONFIGURATION.md
Outdated
|
|
||
| You can configure defaults globally when initializing the low-level GAPIC client, though per-call is preferred for specific logic. | ||
|
|
||
| ```php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/php/ruby
help/CORE_CONCEPTS.md
Outdated
|
|
||
| ### Installation & Setup | ||
|
|
||
| Unlike PHP (which requires PECL), Ruby handles these extensions via Gems. If you are using `google-cloud-*` gems, these dependencies are usually installed automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, sorry about that :(
Adds new directory
helpwhich contains new product-neutral guides. This relies on changes inruby-common-toolsto support this, as it is not a standard gem as the other directories areDepends on: