feat(jdbc): add HttpTransportOptions timeout configuration

[keshavdandeva]

b/454382967

Adds support for configuring HttpConnectTimeout and HttpReadTimeout in the BigQuery JDBC driver via connection properties or the JDBC URL. This allows users to control the connect and read timeouts for the underlying HTTP transport (default: 60,000ms)

[gemini-code-assist]

Summary of Changes

Hello @keshavdandeva, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request empowers users of the BigQuery JDBC driver with greater control over network communication by enabling the configuration of HTTP connection and read timeouts. This enhancement allows for fine-tuning the driver's behavior to better suit various network environments and performance requirements, preventing long-running or stalled connections from impacting application responsiveness.

Highlights

• HTTP Timeout Configuration: Introduced HttpConnectTimeout and HttpReadTimeout properties for the BigQuery JDBC driver.
• Configurability: Users can now specify these timeouts via connection properties or directly in the JDBC URL.
• Default Values: Both connect and read timeouts default to 60,000 milliseconds (60 seconds) if not explicitly set.
• Underlying Transport Control: These settings directly influence the connect and read timeouts of the underlying HTTP transport.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for configuring HttpConnectTimeout and HttpReadTimeout in the BigQuery JDBC driver. The implementation is generally sound and follows existing patterns. However, I've identified a potential breaking change where a default 60-second timeout is applied to all connections, which could impact users with long-running queries. I've provided suggestions across two files to address this by applying timeouts only when explicitly configured by the user. Additionally, I've noted a minor gap in test coverage for the new functionality.

[logachev]

I'd change this to set property only if it is provided, otherwise allow it to use httpTransport default value rather than overriding it