chore: refactor experimental host usage and add instance type support#357
Merged
Conversation
- Deprecate public experimental host APIs in favor of instanceType and spannerEndpoint / SPANNER_ENDPOINT. - Normalize experimentalHostEndpoint to spannerEndpoint and InstanceType.OMNI in GlobalClientConfigs, SpannerCqlSessionBuilder, and LauncherConfig. - Update SpannerContext and test suites to use instanceType and SPANNER_ENDPOINT. - Rename internal default omni constants to SPANNER_OMNI_ID and SPANNER_OMNI_INSTANCE.
mayurkale22
requested review from
ath-08,
mayurkale22 and
pabloecol
and removed request for
pabloecol
July 13, 2026 17:40
mayurkale22
reviewed
Jul 13, 2026
… InstanceType enum - Change GlobalClientConfigs instanceType field and getter to return InstanceType enum instead of String. - Rename SpannerCqlSessionBuilder.setEndpointType to setInstanceType. - Update LauncherConfig, YamlConfigLoaderTest, SpannerCqlSessionBuilderTest, and SpannerContext call sites.
mayurkale22
approved these changes
Jul 20, 2026
pabloecol
reviewed
Jul 21, 2026
- Remove unused Logger in AdapterOptions. - Remove unused test resource invalid-host-conflict-config.yaml. - Update copyright year in AdapterOptionsTest. - Add default InstanceType.CLOUD test in AdapterOptionsTest. - Add default InstanceType.CLOUD assertions in LauncherConfigParserTest.
pabloecol
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup reference of experimental host to replace with instance type=OMNI
sidecar proxy
Integration Test command
Similar PRs for reference:
googleapis/google-cloud-java#13236
GoogleCloudPlatform/pgadapter#4575