chore(internal/serviceconfig): allow list google/developers/knowledge/v1 for java#6240
Closed
zhumin8 wants to merge 3 commits into
Closed
chore(internal/serviceconfig): allow list google/developers/knowledge/v1 for java#6240zhumin8 wants to merge 3 commits into
zhumin8 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the google/developers/knowledge/v1 path to the SDK configuration. A review comment correctly identifies that the singular language key was used instead of the plural languages, which would cause the configuration to be ignored during unmarshaling.
zhumin8
marked this pull request as ready for review
June 1, 2026 15:57
zhumin8
enabled auto-merge (squash)
June 1, 2026 15:57
Contributor
|
We don't need to update |
Contributor
Author
|
@JoeWang1127 Thanks for the pointer! |
auto-merge was automatically disabled
June 1, 2026 16:03
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New API path added for Java in googleapis/google-cloud-java#13313.
For #6173