cleanup(sidekick/swift): library vs. package names#6998
Merged
coryan merged 7 commits intoJul 25, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Swift sidekick generator to separate the hyphenated PackageName from the CamelCase LibraryName. It introduces a new LibraryName helper, updates the codec struct, templates, and tests to use these distinct fields, and ensures correct naming in generated files and dependencies. All review comments have been addressed in the changes, so we have no further feedback to provide.
coryan
marked this pull request as ready for review
July 23, 2026 19:26
nolanleastin
approved these changes
Jul 24, 2026
nolanleastin
left a comment
nolanleastin
left a comment
Contributor
There was a problem hiding this comment.
should generate_package_swift_test.go test this too?
Use different annotations for the package name (e.g. `google-cloud-workflows-v1`) vs. the library name (e.g. `GoogleCloudWorkflowsV1`). In a future PR we will change the default library name and introduce options to override it.
coryan
force-pushed
the
cleanup-swift-library-vs-package-name
branch
from
July 24, 2026 23:48
76d41c6 to
44f36d6
Compare
Contributor
Author
Done. |
coryan
enabled auto-merge (squash)
July 25, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use different annotations for the package name (e.g.
google-cloud-workflows-v1) vs. the library name (e.g.GoogleCloudWorkflowsV1). In a future PR we will change the default library name and introduce options to override it.Towards #6229