fix(internal/librarian/php): remove php fallback generator installation#7038
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the PHP generator setup by removing the fallback installation and location logic, strictly requiring the PHP generator wrapper to be located in the bin directory. It also updates the installation process to enforce the presence of tools and Composer configurations, with corresponding test updates. The feedback highlights a potential issue in the test file where ignoring the error from binDir() could lead to unexpected behavior, suggesting that the error should be handled explicitly.
sofisl
changed the title
sofisl
marked this pull request as ready for review
July 24, 2026 20:07
zhumin8
reviewed
Jul 24, 2026
noahdietz
previously approved these changes
Jul 24, 2026
JoeWang1127
reviewed
Jul 24, 2026
noahdietz
dismissed
their stale review
July 24, 2026 20:23
Another reviewer commented with same comment, want to get alignment
zhumin8
reviewed
Jul 24, 2026
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com> Signed-off-by: sofisl <55454395+sofisl@users.noreply.github.com>
Clarify error handling for PNPM installation. Signed-off-by: sofisl <55454395+sofisl@users.noreply.github.com>
Contributor
|
Could you fix the linter check? |
JoeWang1127
approved these changes
Jul 24, 2026
noahdietz
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the fallback hardocded generator installation for PHP in lieu of the new generator installation command.
For #6630