-
Notifications
You must be signed in to change notification settings - Fork 140
chore: replace old python teams with cloud-sdk-python-team #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates references to an old Python team across various configuration files to reflect a new team, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Python team names across various configuration files. The changes are generally correct and align with the goal of replacing old team names. However, I've identified an issue in the .github/CODEOWNERS file where a team is listed redundantly, and the rule is inconsistent with the accompanying comment. I've provided a suggestion to correct this.
.github/CODEOWNERS
Outdated
| # @googleapis/yoshi-python @googleapis/api-bigquery are the default owners for changes in this repo | ||
| * @googleapis/yoshi-python @googleapis/python-core-client-libraries | ||
| # @googleapis/cloud-sdk-python-team @googleapis/api-bigquery are the default owners for changes in this repo | ||
| * @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a redundant team listed here (@googleapis/cloud-sdk-python-team is mentioned twice). Additionally, this rule is inconsistent with the comment on line 8, which indicates @googleapis/api-bigquery should be a default owner. To resolve the redundancy and align with the comment, please consider this suggestion.
* @googleapis/cloud-sdk-python-team @googleapis/api-bigquery
f23a8e4 to
9646beb
Compare
Bug ID: b/479543683