test: fix conformance tests for SQLAlchemy 2.0#835
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where conformance tests for SQLAlchemy 2.0 were failing due to a dependency conflict related to OpenTelemetry. The changes involve removing OpenTelemetry from the test suite to avoid deprecation warnings and ensure the tests pass reliably. This improves the overall stability and reliability of the testing process. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes failing conformance tests for SQLAlchemy 2.0 by removing OpenTelemetry usage from the test environment. This is achieved by not installing the tracing extras and by monkey-patching trace_call to a no-op function. The changes are logical and effectively address the described issue. I have a couple of suggestions to improve code maintainability.
54ecb56 to
a1c2f11
Compare
The conformance tests for SQLAlchemy 2.0 were failing due to a dependency conflict for OpenTelemetry. This change removes the use of OpenTelemetry entirely from the tests, as the version that is currently used by the Spanner client library triggers a deprecation warning when used with SQLAlchemy. That in itself is not a big problem, except that the SQLAlchemy tests verify that there are no warnings, and there are no reasonable ways to ignore these warnings, other than just getting rid of the OpenTelemetry usage.
a1c2f11 to
face32a
Compare
The conformance tests for SQLAlchemy 2.0 were failing due to a dependency conflict for OpenTelemetry. This change removes the use of OpenTelemetry entirely from the tests, as the version that is currently used by the Spanner client library triggers a deprecation warning when used with SQLAlchemy. That in itself is not a big problem, except that the SQLAlchemy tests verify that there are no warnings, and there are no reasonable ways to ignore these warnings, other than just getting rid of the OpenTelemetry usage.
See https://github.com/googleapis/python-spanner-sqlalchemy/actions/runs/22582034832/job/65569068380?pr=825 for an example of the build error that is being fixed.