Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@ def system(session):

session.install("mock")
session.install(".[tracing]")
session.install("opentelemetry-api==1.27.0")
session.install("opentelemetry-sdk==1.27.0")
session.install("opentelemetry-instrumentation==0.48b0")
session.install("opentelemetry-api")
session.install("opentelemetry-sdk")
session.install("opentelemetry-instrumentation")
session.run("python", "create_test_database.py")

session.install("sqlalchemy>=2.0")
Expand All @@ -254,9 +254,9 @@ def unit(session):
session.install("pytest")
session.install("mock")
session.install(".")
session.install("opentelemetry-api==1.27.0")
session.install("opentelemetry-sdk==1.27.0")
session.install("opentelemetry-instrumentation==0.48b0")
session.install("opentelemetry-api")
session.install("opentelemetry-sdk")
session.install("opentelemetry-instrumentation")
session.run(
"python", "create_test_config.py", "my-project", "my-instance", "my-database"
)
Expand Down
12 changes: 6 additions & 6 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,9 @@ MarkupSafe==3.0.3 \
--hash=sha256:f9e130248f4462aaa8e2552d547f36ddadbeaa573879158d721bbd33dfe4743a \
--hash=sha256:fed51ac40f757d41b7c48425901843666a6677e3e8eb0abcff09e4ba6e664f50
# via mako
opentelemetry-api==1.38.0 \
--hash=sha256:2891b0197f47124454ab9f0cf58f3be33faca394457ac3e09daba13ff50aa582 \
--hash=sha256:f4c193b5e8acb0912b06ac5b16321908dd0843d75049c091487322284a3eea12
opentelemetry-api==1.40.0 \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The opentelemetry-api and opentelemetry-sdk dependencies are being updated to 1.40.0, but the test environments defined in noxfile.py are hardcoded to use version 1.27.0 for both unit and system tests.

This discrepancy means that the tests are not running against the new versions of these dependencies, and any potential regressions or issues introduced by this upgrade could be missed.

To ensure the stability of the project, please update the pinned versions in noxfile.py to match the versions in this pull request.

For example, in noxfile.py:

# in system() session
session.install("opentelemetry-api==1.40.0")
session.install("opentelemetry-sdk==1.40.0")

# in unit() session
session.install("opentelemetry-api==1.40.0")
session.install("opentelemetry-sdk==1.40.0")

This will ensure that your test suite properly validates the updated dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the version restrictions for OpenTelemetry in the tests.

--hash=sha256:159be641c0b04d11e9ecd576906462773eb97ae1b657730f0ecf64d32071569f \
--hash=sha256:82dd69331ae74b06f6a874704be0cfaa49a1650e1537d4a813b86ecef7d0ecf9
# via
# -r requirements.in
# opentelemetry-instrumentation
Expand All @@ -427,9 +427,9 @@ opentelemetry-instrumentation==0.48b0 \
--hash=sha256:94929685d906380743a71c3970f76b5f07476eea1834abd5dd9d17abfe23cc35 \
--hash=sha256:a69750dc4ba6a5c3eb67986a337185a25b739966d80479befe37b546fc870b44
# via -r requirements.in
opentelemetry-sdk==1.38.0 \
--hash=sha256:1c66af6564ecc1553d72d811a01df063ff097cdc82ce188da9951f93b8d10f6b \
--hash=sha256:93df5d4d871ed09cb4272305be4d996236eedb232253e3ab864c8620f051cebe
opentelemetry-sdk==1.40.0 \
--hash=sha256:18e9f5ec20d859d268c7cb3c5198c8d105d073714db3de50b593b8c1345a48f2 \
--hash=sha256:787d2154a71f4b3d81f20524a8ce061b7db667d24e46753f32a7bc48f1c1f3f1
# via -r requirements.in
opentelemetry-semantic-conventions==0.55b1 \
--hash=sha256:5da81dfdf7d52e3d37f8fe88d5e771e191de924cfff5f550ab0b8f7b2409baed \
Expand Down
Loading